Skip to content

Boost 'id' by not parsing types from dwarf for filelines ##bin #25138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trufae wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −6
Open

Boost 'id' by not parsing types from dwarf for filelines ##bin #25138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions libr/bin/dwarf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2618,9 +2618,11 @@ R_API RBinDwarfDebugInfo *r_bin_dwarf_parse_info(RBin *bin, RVecDwarfAbbrevDecl
if (!info) {
return NULL;
}
if (mode == R_MODE_PRINT) {
print_debug_info (info, bin->cb_printf);
}
// Don't print debug info automatically - it causes severe performance issues
// for large binaries. To debug DWARF, use explicit commands.
// if (mode == R_MODE_PRINT) {
// print_debug_info (info, bin->cb_printf);
// }

// TODO: load compilation units
// TODO: only necessary when we have no srcline inf
Expand Down Expand Up @@ -2748,9 +2750,12 @@ R_API RVecDwarfAbbrevDecl *r_bin_dwarf_parse_abbrev(RBin *bin, int mode) {
return NULL;
}
RVecDwarfAbbrevDecl *abbrevs = parse_abbrev_raw (buf, section->bytes.len);
if (mode == R_MODE_PRINT && abbrevs) {
print_abbrev_section (abbrevs, bin->cb_printf);
}
// Don't print abbreviations automatically - they're internal DWARF data
// and printing them causes performance issues for large binaries.
// To debug DWARF, use explicit commands like 'idi' instead.
// if (mode == R_MODE_PRINT && abbrevs) {
// print_abbrev_section (abbrevs, bin->cb_printf);
// }
return abbrevs;
}

Expand Down
Loading