Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive logging to SDK method calls during React Native QA testing. The changes enhance debugging capabilities by logging method names along with their parameter values when SDK methods are invoked.
- Enhanced existing log statements to include parameter values for better debugging
- Added new logging statements to previously unlogged SDK methods
- Improved log formatting for methods with array parameters using
joinToString()andcontentToString()
| return | ||
| } | ||
| this.logger.i( | ||
| "validateAddress(address=${address?.toJson()})", |
There was a problem hiding this comment.
Calling toJson() on the address object for logging purposes may impact performance, especially if this method is called frequently. Consider using a simpler string representation or adding a null check to avoid unnecessary serialization.
Suggested change
| "validateAddress(address=${address?.toJson()})", | |
| "validateAddress(address=${address?.toString() ?: "null"})", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added logging during react native qa