Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a setPublishableKey method to allow updating the publishable key without re-initializing the SDK, primarily intended for use with ephemeral API keys. The method provides a way to dynamically change the API key at runtime.
- Adds a new public method
setPublishableKeyto the Radar SDK interface - Includes documentation explaining its purpose for ephemeral API keys
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| RadarSDK/Include/Radar.h | Declares the new setPublishableKey method with proper parameter annotations and documentation |
| RadarSDK/Radar.m | Implements the new method by delegating to RadarSettings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| + (void)setPublishableKey:(NSString *)key { | ||
| return [RadarSettings setPublishableKey:key]; |
There was a problem hiding this comment.
This method has a void return type, so it should not have a return statement. The return statement should be removed to match the pattern used by other setter methods in this file like setUserId and setDescription.
Suggested change
| return [RadarSettings setPublishableKey:key]; | |
| [RadarSettings setPublishableKey:key]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for ephemeral user keys
tested with example app, can set publishable key to different value (UNAUTHORIZED) then back (successful track)