feat: improve sort return type when sorting a tuple#421
Open
nnmrts wants to merge 3 commits intoradashi-org:mainfrom
Open
feat: improve sort return type when sorting a tuple#421nnmrts wants to merge 3 commits intoradashi-org:mainfrom
sort return type when sorting a tuple#421nnmrts wants to merge 3 commits intoradashi-org:mainfrom
Conversation
4 tasks
Member
|
Tests are failing |
Contributor
Author
Thanks for the update. I resolved the merge conflicts, tests seem to be okay now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an overload to
sortto preserve tuple types.resultabove had this type before:with this PR, it now has this type:
which preserves the tuple type and length.
Related issue, if any:
For any code change,
Does this PR introduce a breaking change?
No