Issue 613: Locking _dispatch_action#614
Open
eloise-nebula wants to merge 4 commits intoradiasoft:masterfrom
Open
Issue 613: Locking _dispatch_action#614eloise-nebula wants to merge 4 commits intoradiasoft:masterfrom
eloise-nebula wants to merge 4 commits intoradiasoft:masterfrom
Conversation
robnagler
requested changes
Sep 18, 2025
Member
robnagler
left a comment
robnagler
left a comment
There was a problem hiding this comment.
This looks great. Only a few comments.
robnagler
requested changes
Oct 1, 2025
| self._destroy() | ||
| except Exception as e: | ||
| pkdlog("error={} {} stack={}", e, self, pkdexc(simplify=True)) | ||
| with self.__lock: |
Member
There was a problem hiding this comment.
if self.__destroyed:
return
self.__destroyed = True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rough sketch of my solution to #613. Moves
_dispatch_actionand_destroyout of locks, but ensures that these two will never run simultaneously by letting the thread handle sequencing. Thread still exits onself.__destroyedsuch that no additional work can be done. If_dispatch_actionis doing significant work it could take a while to exit, but that was already a problem. Plus, the newis_destroyedfunction provides a threadsafe way of checking the lifecycle flag from within_dispatch_action.