Conversation
aknierim
requested changes
Sep 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 34.39% 35.64% +1.24%
==========================================
Files 8 8
Lines 407 404 -3
Branches 70 0 -70
==========================================
+ Hits 140 144 +4
+ Misses 263 260 -3
+ Partials 4 0 -4 ☔ View full report in Codecov by Sentry. |
aknierim
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgraded the pinned version for
numpyinpyproject.tomlto avoid potential conflicts.Updated the docstring for the
vis_dataattribute inGridDatato specify its shape for better clarity.Improved data selection and masking logic in
GridData.from_msto ensure correct row selection, flag masking, and shape alignment for measurement and channel data. This also fixes the handling of flagged data and ensures that the returned arrays are correctly filtered and shaped.