Skip to content

Fix Measurement Set Gridding#29

Merged
tgross03 merged 6 commits intomainfrom
fix_ms_gridding
Sep 25, 2025
Merged

Fix Measurement Set Gridding#29
tgross03 merged 6 commits intomainfrom
fix_ms_gridding

Conversation

@tgross03
Copy link
Member

  • Downgraded the pinned version for numpy in pyproject.toml to avoid potential conflicts.

  • Updated the docstring for the vis_data attribute in GridData to specify its shape for better clarity.

  • Improved data selection and masking logic in GridData.from_ms to ensure correct row selection, flag masking, and shape alignment for measurement and channel data. This also fixes the handling of flagged data and ensures that the returned arrays are correctly filtered and shaped.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.64%. Comparing base (2506995) to head (f263eec).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pyvisgrid/core/gridder.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   34.39%   35.64%   +1.24%     
==========================================
  Files           8        8              
  Lines         407      404       -3     
  Branches       70        0      -70     
==========================================
+ Hits          140      144       +4     
+ Misses        263      260       -3     
+ Partials        4        0       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tgross03 tgross03 requested a review from aknierim September 25, 2025 13:02
@tgross03 tgross03 merged commit d1592cd into main Sep 25, 2025
8 checks passed
@tgross03 tgross03 deleted the fix_ms_gridding branch September 25, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants