Skip to content

Make pyvisgen dependency optional#7

Merged
tgross03 merged 1 commit intomainfrom
update_dependencies
Jul 4, 2025
Merged

Make pyvisgen dependency optional#7
tgross03 merged 1 commit intomainfrom
update_dependencies

Conversation

@tgross03
Copy link
Member

@tgross03 tgross03 commented Jul 4, 2025

  • Made pyvisgen dependency optional and moved import to if TYPE_CHECKING clause to only import it for type hinting

Fixes #5

@tgross03 tgross03 requested a review from aknierim July 4, 2025 14:56
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.40%. Comparing base (9c90c2f) to head (c5ef9c4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pyvisgrid/core/gridder.py 50.00% 1 Missing and 1 partial ⚠️
pyvisgrid/core/stokes.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   45.61%   45.40%   -0.22%     
==========================================
  Files           7        7              
  Lines         331      337       +6     
  Branches       53       55       +2     
==========================================
+ Hits          151      153       +2     
- Misses        174      176       +2     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tgross03 tgross03 merged commit 324818f into main Jul 4, 2025
3 checks passed
@tgross03 tgross03 deleted the update_dependencies branch July 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependence on pyvsigen

3 participants