Skip to content

feat!: GST 2026 changes#874

Merged
hairmare merged 35 commits intomainfrom
release/gst-2026
Feb 2, 2026
Merged

feat!: GST 2026 changes#874
hairmare merged 35 commits intomainfrom
release/gst-2026

Conversation

@hairmare
Copy link
Member

@hairmare hairmare commented Dec 20, 2025

@hairmare hairmare changed the title chore: configure semrelrc for pre-releasing feat!: GST 2026 changes Dec 21, 2025
@hairmare hairmare marked this pull request as ready for review December 26, 2025 07:57
@hairmare
Copy link
Member Author

hairmare commented Dec 27, 2025

The v1.0.0-alpha.5 is currently configured to send additional test mails from our production infrastructure. We will be getting a test mail for Dec 2025 as well as Jan 2026, giving us enough time to fix anything if the need arises.

Once the Dec 2025 mail has been received by SUISA (in mid Jan), we'll proceed with merging this,

Copy link
Member

@paraenggu paraenggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the adaptation to the new GST 2026!

Please find some smaller fixes and comments within my review.

Co-authored-by: Christian Affolter <christian.affolter@purplehaze.ch>
@hairmare
Copy link
Member Author

@paraenggu I merged most changes and added some feedback for others. I updated prod to use v1.0.0-alpha.6 in the next test run.

wrt "Erstveröffentichungsdatum" i think we get to decide if we want to keep the typo that was most likely proposed by SUISA and ratified by ESchK. It's kinda disturbing how many people were involved in the new GST and none of them seems to have had a working spellchecker.

Anyway, i'm not sure if keeping the typo might be to petty, so we could consider fixing the spelling. In this context we might also refer to the text of the GST, where the column is called "(Erst-)Veröffentlichungsdatum bzw. -jahr".

My understanding is that this text won't have any impact on SUISA's ability to process our reports, hence i would propbably make it match the template, leaving the typo in the report (as currently implemented).

@paraenggu
Copy link
Member

I merged most changes and added some feedback for others. I updated prod to use v1.0.0-alpha.6 in the next test run.

Great, thank you!

wrt "Erstveröffentichungsdatum" i think we get to decide if we want to keep the typo that was most likely proposed by SUISA and ratified by ESchK.

That one is correctly spelled in the template (see comment r2650351762), but "Veröffentlichungsland" is still wrong in the template.

As mentioned, I would prefer that the corrected spelling be used from the beginning, rather than including typos in the newly generated output. If any complaints arise, the typo can still be reintroduced as needed.

@hairmare
Copy link
Member Author

"Veröffentichung" typo was fixed across the board. I'm still working on input validation for the ACR settings.

@hairmare
Copy link
Member Author

hairmare commented Jan 2, 2026

Feedback from mail (sent by @paraenggu)

Mail-Text

Abstimmung:

[...] sowie der Abstimmung zwischen SUISA und TEST Radio Bern RaBe TEST.

Würde diesen Teil streichen, es gab keine Abstimmung wie beim letzten
mal als wir den automatischen Report einführten.

  • 👍

Subsidiäre Angaben:

Die folgenden subsidiären Angaben werden in allen Fällen gemeldet, in denen diese vom Lieferanten der Aufnahme mitgeteilt oder mitgeliefert wurden, insbesondere in Fällen, in denen der Lieferant der Aufnahme keine ISRC mitgeteilt oder mitgeliefert hat.

Ich schlage vor den Text hier etwas anzupassen. Wir liefern die Angaben
ja immer sofern verfügbar und nicht nur, oder wie geschrieben
insbesondere, bei fehlender ISRC. Ebenfalls empfehle ich hier die
Formulierung bezüglich "verfügbar/zugänglich" aus dem Tarif aufzugreifen.

Im Tarif steht zu den subsidiären Angaben folgendes:

Falls der ISRC nicht gemeldet wird, sind subsidiär folgende Angaben zu machen, sofern diese beim Sender verfügbar oder für ihn leicht zugänglich sind:

Vorschlag:

Ebenfalls sind folgende subsidiäre Angaben enthalten, sofern sie für den
Sender verfügbar oder leicht zugänglich sind:

  • EAN / GTIN (European Article Number / Global Trade Item Number)
  • Albumtitel / Titel des Tonträgers
  • [...]
  • The ideas was indeed that the whole "mitgeteilt oder mitgeliefert" would also cover this, but using "verfügbar oder leicht zugänglich" makes more sense.

Zeilenlänge (kosmetisch):

Die Zeilenlänge der Mail war zuvor auf eine maximale Länge
vereinheitlicht. Nun hat es gewisse Abschnitte welche länger sind.

  • I'll probably change it to be a single line per paragraph, thus letting the MUA do the formatting. needs fixing

Sendemeldung

Dateinahme:

Der Dateiname heisst test_2025-12-02.xlsx statt test_2025-12.xlsx - Ist
dies bedingt durch dein Test oder hat sich da noch ein "DD" (Tag) im
Dateinamen eingeschlichen?

  • The "last month" mode seems to be broken somewhere, this affects both the filename as well as the start and end date.

Spaltenbezeichnung:

Die Splate "L" ist mit "EAN/GTIN" bezeichnet, in der Vorlage heisst
diese "EAN / GTIN" (Leerzeichen vor und nach dem Schrägstrich).

  • 👍

Farbe:

Farbe für "zwingend, falls kein ISRC" Felder stimmt nicht mit dem "grün"
aus der öffentlich publizierten Vorlage überein, müsste #ebf1de sein.

  • 👍

Start- & Endzeitpunkt sind falsch:

Der Rapport beginnt am 02.12.2025 statt am 01.12. und gehen bis zum
01.01.2026 08:53:26 statt bis zum 31.12 23:59

  • Seems to be related to the filename issue above, I'll double check this and try to figure out where i missed a test.

Sendedatum:

In der Spalte Sendedatum ist neu ebenfalls eine Uhrzeit enthalten, z.B.:
"02.12.2025 00:00:31"
Hier sollte nur das Datum vorhanden sein, damit es nicht zu Problemen
auf Seite SUISA-Import kommt.

  • Needs fixing, I'm not sure where i introduced it yet.

Leere "zwingend, falls kein ISRC" Felder:

Die folgenden Felder, welche als "zwingend falls kein ISRC und
verfügbar" eingestuft sind, sind immer leer:

  • Aufnahmedatum
  • Aufnahmeland
  • Katalog-Nummer / CD ID
  • Werkverzeichnisangaben
  • Bestellnummer

Gibt es hierzu von Seite ACRCloud weiterhin keine zusätzlichen Daten?

Identifikationsnummer:

Der Sendenamen innerhalb der crid scheint mittlerweile der korrekten
Uhrzeit zu entsprechen - hurra 🥳

🎉

I'll fix these and then resend the Dec mail!

@hairmare
Copy link
Member Author

hairmare commented Jan 2, 2026

New fields:

Aufnahmedatum

We only have "release_date" in our records, information on the date of the recording does not seem to be publicaly available.

Aufnahmeland

There are some complex data structures under "release_by_territories", they don't seem to be relevant to the country of recording but rather contain deal related information from the music industry at large. The data structure in our results is also not consistent and we would require better documentation to make sense of the data.

Katalog-Nummer / CD ID

The CD_ID is available in some album records, so we can add it.

The tarif describes the "Katalog-Nummer" as "Katalognummer des Tonträgers beim Label". The way our provisioning of samples (Bemusterung) works, it doesn't look like we have this info as it seems to be specific to individual labels.

Werkverzeichnisangaben

This would be something like "Opus n", it's rarely applicable outside of classical music and also doesn't seem to be available in ACR.

Bestellnummer

I have zero clues what this is, the tarif doesn't seem to have any further details.

@hairmare
Copy link
Member Author

hairmare commented Jan 16, 2026

last-month mode seems to have not been addressed in the beta image

  • fix filename issue again (needs to be rabe_<year>-<month> not rabe_<year>-<month>-<day>
  • fix start date issue again (needs to start at the 1st of the last month, no at the day of execution)

both cases are related to the last-month mode not properly doing it's thing, i did some fixing in this area for beta.1, but my fixes seem to have missed the mark

@hairmare
Copy link
Member Author

hairmare commented Jan 26, 2026

1.0.0-beta.3 will be sent from our main production infrastructure's preview configuration.

Once we are happy with the results, all that will be left to do is to merge this PR and remove the beta tag from the preview configuration, the production configuration is already prepared for the change.

  • remove semrelrc before merge

@hairmare hairmare merged commit d825fca into main Feb 2, 2026
7 checks passed
@hairmare hairmare deleted the release/gst-2026 branch February 2, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants