Conversation
|
The v1.0.0-alpha.5 is currently configured to send additional test mails from our production infrastructure. We will be getting a test mail for Dec 2025 as well as Jan 2026, giving us enough time to fix anything if the need arises. Once the Dec 2025 mail has been received by SUISA (in mid Jan), we'll proceed with merging this, |
paraenggu
left a comment
There was a problem hiding this comment.
Thanks a lot for the adaptation to the new GST 2026!
Please find some smaller fixes and comments within my review.
Co-authored-by: Christian Affolter <christian.affolter@purplehaze.ch>
|
@paraenggu I merged most changes and added some feedback for others. I updated prod to use v1.0.0-alpha.6 in the next test run. wrt "Erstveröffentichungsdatum" i think we get to decide if we want to keep the typo that was most likely proposed by SUISA and ratified by ESchK. It's kinda disturbing how many people were involved in the new GST and none of them seems to have had a working spellchecker. Anyway, i'm not sure if keeping the typo might be to petty, so we could consider fixing the spelling. In this context we might also refer to the text of the GST, where the column is called "(Erst-)Veröffentlichungsdatum bzw. -jahr". My understanding is that this text won't have any impact on SUISA's ability to process our reports, hence i would propbably make it match the template, leaving the typo in the report (as currently implemented). |
Great, thank you!
That one is correctly spelled in the template (see comment r2650351762), but "Veröffentlichungsland" is still wrong in the template. As mentioned, I would prefer that the corrected spelling be used from the beginning, rather than including typos in the newly generated output. If any complaints arise, the typo can still be reintroduced as needed. |
|
"Veröffentichung" typo was fixed across the board. I'm still working on input validation for the ACR settings. |
|
Feedback from mail (sent by @paraenggu)
🎉 I'll fix these and then resend the Dec mail! |
|
New fields:
We only have "release_date" in our records, information on the date of the recording does not seem to be publicaly available.
There are some complex data structures under "release_by_territories", they don't seem to be relevant to the country of recording but rather contain deal related information from the music industry at large. The data structure in our results is also not consistent and we would require better documentation to make sense of the data.
The CD_ID is available in some album records, so we can add it. The tarif describes the "Katalog-Nummer" as "Katalognummer des Tonträgers beim Label". The way our provisioning of samples (Bemusterung) works, it doesn't look like we have this info as it seems to be specific to individual labels.
This would be something like "Opus n", it's rarely applicable outside of classical music and also doesn't seem to be available in ACR.
I have zero clues what this is, the tarif doesn't seem to have any further details. |
… know about any of our own recordings so far
|
last-month mode seems to have not been addressed in the beta image
both cases are related to the last-month mode not properly doing it's thing, i did some fixing in this area for beta.1, but my fixes seem to have missed the mark |
|
1.0.0-beta.3 will be sent from our main production infrastructure's preview configuration. Once we are happy with the results, all that will be left to do is to merge this PR and remove the beta tag from the preview configuration, the production configuration is already prepared for the change.
|
This PR contains the changes for GST 2026 as well as the configuration for doing prereleases.
Once merged, we will be moving towards a stable v1 version of the tool.
pre-committo dev dependencies #75