Draft
Conversation
Signed-off-by: sk593 <shruthikumar@microsoft.com>
add oidc config
Signed-off-by: sk593 <shruthikumar@microsoft.com>
Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
sk593
requested a deployment
to
external-contributor-approval
GitHub Actions
Waiting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| echo "AZURE_SUBSCRIPTION_ID is set: ${{ vars.AZURE_SUBSCRIPTION_ID != '' }}" | ||
|
|
||
| - name: Azure Login via OIDC | ||
| uses: azure/login@v2 |
Unit Tests 1 files - 1 336 suites - 79 6m 35s ⏱️ -3s For more details on these failures, see this check. Results for commit 1735c4f. ± Comparison against base commit 2ea450a. This pull request removes 6 and adds 35 tests. Note that renamed tests count towards both. |
| req.Header.Set("Content-Type", "application/json") | ||
| } | ||
|
|
||
| resp, err := v.httpClient.Do(req) |
| req.Header.Set("Content-Type", "application/json") | ||
| } | ||
|
|
||
| return c.httpClient.Do(req) |
| writeError(w, http.StatusBadRequest, "missing OAuth state cookie") | ||
| return | ||
| } | ||
| if r.URL.Query().Get("state") != stateCookie.Value { |
Comment on lines
+307
to
+312
| http.SetCookie(w, &http.Cookie{ | ||
| Name: "oauth_state", | ||
| Value: "", | ||
| Path: "/", | ||
| MaxAge: -1, | ||
| }) |
Comment on lines
+307
to
+312
| http.SetCookie(w, &http.Cookie{ | ||
| Name: "oauth_state", | ||
| Value: "", | ||
| Path: "/", | ||
| MaxAge: -1, | ||
| }) |
| if config.AuthType != AuthTypeWorkloadIdentity && config.AuthType != AuthTypeServicePrincipal { | ||
| return nil, fmt.Errorf("auth type must be %q or %q", AuthTypeWorkloadIdentity, AuthTypeServicePrincipal) | ||
| } | ||
| if config.AuthType == AuthTypeServicePrincipal && config.ClientSecret == "" { |
| } | ||
|
|
||
| // 3. For Service Principal, store the client secret as a GitHub Environment secret. | ||
| if config.AuthType == AuthTypeServicePrincipal { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made.
Type of change
Fixes: #issue_number
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: