fix(Presence): handle escape characters in animation names correctly #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8b6ce90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes radix-ui#2763. Using [CSS.escape](https://developer.mozilla.org/en-US/docs/Web/API/CSS/escape_static). As I checked, this API is supported in all browsers even in the [2022 browserslist targets](radix-ui#1019 (comment)) of this project. Further explanation of the bug: `getComputedStyle()` returns a `CSSStyleDeclaration`, which is serialized according to the spec. Meanwhile, the values from `AnimationEvent` are not required to be serialized (which makes sense, as it's intended for JavaScript usage, where escaping for CSS syntax is unnecessary). Therefore the `animationName` is returned as-is in the event handler, causing the mismatch.
haoqunjiang
force-pushed
the
fix-presence-animation-name-escape
branch
from
49e599e to
8b6ce90
Compare
chaance
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2763.
Using CSS.escape.
As I checked, this API is supported in all browsers even in the 2022 browserslist targets of this project.
Further explanation of the bug:
getComputedStyle()returns aCSSStyleDeclaration, which is serialized according to the spec.Meanwhile, the values from
AnimationEventare not required to be serialized (which makes sense, as it's intended for JavaScript usage, where escaping for CSS syntax is unnecessary). Therefore theanimationNameis returned as-is in the event handler, causing the mismatch.Preview of the bug fix based on the original reproduction: https://stackblitz.com/edit/vitejs-vite-dm8pji1o
I'd like to add a test for this case if it's required—but I don't see any similar tests in Cypress or Storybook, so I don't know what kind of test it should be.