[OneTimePasswordField] Fix iOS Chrome autocomplete #3654
Merged
+24
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS chrome autocomplete only fires an `input` event up to the `maxLength`, so we need the input that “supports autocomplete” to accept the full OTP length. Later, in the `input` handler, the PASTE action will be dispatched.
🦋 Changeset detectedLatest commit: f7ad0d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
controversial
changed the title
- iOS Chrome fires onChange for the first input after firing `onInput` with the full code - If unchecked, the onChange handler will result in the _second_ input being pressed, after the PASTE action handler already focused the _final_ input
|
Compared to #3643, this PR:
|
chaance
approved these changes
Aug 14, 2025
|
@controversial Had an accidental lint error slip through on main. Mind updating your branch so tests can re-run in CI? |
|
@chaance I just rebased off the latest main; lints and tests are now passing, at least on my local |
|
@chaance It looks like this was released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autocomplete in
OneTimePasswordFields is broken on iOS Chrome, see #3641.This is because:
OneTimePasswordFieldInputexpects a password manager / autocomplete provider to enter the full code in the first input. When it encounters this case in theinputevent handler, it dispatches thePASTEaction.inputevent’s value for themaxLengthproperty set on the target inputThe solution is to increase the
maxLengthon the input that expects to receive autocomplete input (the input that hassupportsAutoComplete) so that it can receive up tocollection.sizecharacters of input, rather than just one.Closes #3641.
Adds additional handling for a bug caused by iOS Chrome firing
onChangeon the first input after it fires theinputevent—this had caused OneTimePasswordField to focus the second input where it should be focusing the final input (of the “pasted” value).(I’m not sure how to add tests for this PR as it’s specific to the iOS chrome environment, but I can try)