Popover: only set aria-controls if open #3773
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 239e4b2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kosta
force-pushed
the
popover-set-aria-controls-only-when-open
branch
from
23efc22 to
239e4b2
Compare
Author
|
Hi! It's been a good month since I created this bugfix PR. Maybe it was overlooked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment, we always set
aria-controlsin thePopover.Trigger, even ifcontext.openis false, i.e. when there should be no element with the given id. This is illegal: We must only provide this id if the element exists.Fix: Only render
aria-controlsifcontext.open.Similar logic already exists e.g. in
TooltipTrigger aria-describedbyI could not find tests for this component (I can create a new test file if you want).
The functionality is already covered in the existing Storybook.