Open
Conversation
🦋 Changeset detectedLatest commit: 4ca1268 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
52180cb to
e051b29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3703
Issue Summary
The Toast component's internal close timer (
closeTimerRef) is not cleared when the component unmounts. This causesReferenceError: document is not definederrors in test environments.Reproduction scenario:
handleClosetries to accessdocument.activeElementdocumentdoesn't exist in test environmentSolution
Added a cleanup effect in
ToastImplto clearcloseTimerRefon unmount:This follows the same pattern used in other Radix components:
HoverCard(hover-card.tsx:89-94)NavigationMenu(navigation-menu.tsx:171-177)Changes
packages/react/toast/src/toast.tsxpackages/react/toast/src/toast.test.tsx