Add explicit role to child div of ScrollAreaViewport#3801
Open
andrewhayward wants to merge 1 commit intoradix-ui:mainfrom
Open
Add explicit role to child div of ScrollAreaViewport#3801andrewhayward wants to merge 1 commit intoradix-ui:mainfrom
andrewhayward wants to merge 1 commit intoradix-ui:mainfrom
Conversation
The `ScrollAreaViewport` renders a `div` with a `display: table` style. This can cause issues in browsers (such as Chrome) that implicitly generate an element role based on specific heuristics; in this case, `role: LayoutTable`. By adding an explicit `role: presentation` to this node, we prevent any guessing by the browser, ensuring that no additional and unexpected semantics are included in the accessibility tree.
|
andrewhayward
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ScrollAreaViewportrenders adivwith adisplay: tablestyle. This can cause issues in browsers (such as Chrome) that implicitly generate an element role based on specific heuristics; in this case,role: LayoutTable.By adding an explicit
role: presentationto this node, we prevent any guessing by the browser, ensuring that no additional and unexpected semantics are included in the accessibility tree.