Bump react-remove-scroll to 2.7.2 for iOS text selection fix in Dialog#3802
Open
f3ndot wants to merge 3 commits intoradix-ui:mainfrom
Open
Bump react-remove-scroll to 2.7.2 for iOS text selection fix in Dialog#3802f3ndot wants to merge 3 commits intoradix-ui:mainfrom
f3ndot wants to merge 3 commits intoradix-ui:mainfrom
Conversation
🦋 Changeset detectedLatest commit: cdadc4a The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Thank you @maiconcarraro for the original fix. Hoping to roll it into the radix-ui primitives here. |
|
Happy to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There has been a subtle long-standing bug expressed in Radix dialogs (and perhaps other primitives) due to the
react-remove-scrolldependency. iOS users are unable to move the text selection handles within a dialog box. This was reported theKashey/react-remove-scroll#130 and fixed in theKashey/react-remove-scroll#144.This was also reported to this repo by a few people over the years:
Fixes #2492
Fixes #3331
Bumping the
react-remove-scrollversion to 2.7.2 applies the fix. I confirmed by putting some inputs in the Dialog Storybook, and selecting text with my iOS 26 iPhone:ScreenRecording_02-04-2026.15-00-23_1.mov