Draft
Conversation
raetha
approved these changes
Dec 10, 2021
Owner
raetha
left a comment
raetha
left a comment
There was a problem hiding this comment.
These changes look good as well. Thanks!
p.s. Please feel free to give yourself some credit in the readme. I've been struggling to find time for hobbies lately, and really happy to have this project living on.
Owner
|
@drinfernoo I just took the huge set of fixes and updates from @nabahr which changed a fair amount, and may have included some, but not all, or this PR. Could you validate that these changes still make sense and if so, migrate the PR to the main branch? It also looks as though it was never moved out of draft, which is why I didn't pull it years ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47