Fix for Neos leak sensor humidity and temperature Issue #93#94
Merged
raetha merged 1 commit intoraetha:develfrom Nov 16, 2025
Merged
Fix for Neos leak sensor humidity and temperature Issue #93#94raetha merged 1 commit intoraetha:develfrom
raetha merged 1 commit intoraetha:develfrom
Conversation
Owner
|
This looks good! I just want to do a quick review from a computer and then will merge into devel for quick testing before releasing v3.1 that includes it. |
raetha
approved these changes
Nov 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per issue #93 changing
if sensor_type != SENSOR_TYPE_CLIMATE:to
if sensor_type not in (SENSOR_TYPE_CLIMATE, SENSOR_TYPE_LEAK):Enables the alarms to be correctly picked up.
This PR also adds the entities necessary to report the humidity and temperature to Home Assistant.
Note: This Neos sensor reports temperature in Celcius and not Farenheit, which is different to how the temperature sensor reports as per issue "Temp Sensor report Fahrenheit not Celsius" #85.
You can now see with these changes the sensor is reading all values correctly into Home Assistant:
