fix rmate -w; fix opening multiple files
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owTextDocument()
…an array instead of a single instance variable
``` This activation event can be removed as VS Code generates these automatically from your package.json contribution declarations. ```
revert rootDir change and list config by string if this should cause any problems
Docs: ``` An array to which disposables can be added. When this extension is deactivated the disposables will be disposed. Note that asynchronous dispose-functions aren't awaited. ```
- TextMate sends a separate `close` message for each closed tab (e.g. if several files were opened with `rmate file1 file2`). - The token is appended to each `close` message. - Sending without a token breaks the stdin function of at least [aurora/rmate](https://github.com/aurora/rmate)'s implementation. - With the current VS Code workaround of having to close files manually because `vscode.workspace.onDidCloseTextDocument` is sometimes triggered after minutes, there is no real need to send a `close` message individually, but we will do so anyway so that it is clean.
Path on Windows looks like:
/c:/Users/Simon/AppData/Local/Temp/rmate-vscode/4WFxHSBiGf/testserver/test
C:\\Users\\Simon\\AppData\\Local\\Temp\\rmate-vscode\\4WFxHSBiGf\\testserver\\test
Simple string compare failed before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed some stuff regarding publisher, name etc. to make a working fork until you decide to pull the suff here. Just edit
package.jsonback to your project.Improvements:
Open multiple files at once with
rmate file1 file2Closing files with
-wflag which is useful for using rmate inEDITOR-env variable.Example:
EDITOR='rmate -w' sudoedit somefileDue to a limitation in VS Code API (currently there's no API that would notify our Extetnsion when the user closed a Tab) we implemented a buttton here to alternatively close the Tab and the rmate-Session behind:
Alternatively there's a command for closing single
Sessions or all Sessions at once: