Fix typos. #65
Merged
Fix typos. #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalh
requested changes
May 29, 2022
Owner
rafalh
left a comment
rafalh
left a comment
There was a problem hiding this comment.
I am totally willing to accept typo fixes (I am surprised how they got in the codebase 😅 ) but other changes are controversial for me. Perhaps you can split them into other PR (that is also properly named)
Contributor
Author
|
Moved the other changes to #67. |
Contributor
Author
|
@rafalh, can you take another look at this? |
Contributor
Author
|
@rafalh, can you merge this? Thanks. |
rafalh
approved these changes
Oct 14, 2022
Owner
|
@reitermarkus Thanks for your contribution. Sorry for keeping you waiting so long... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add missing
Debugimplementations.