Open
Conversation
Merged
rafalh
reviewed
Oct 14, 2022
| run_tests: true | ||
| # Minimal supported rustc version | ||
| - rust_version: 1.46.0 | ||
| - rust_version: 1.47.0 |
Contributor
Author
There was a problem hiding this comment.
Deriving Debug for fixed-sized arrays needs 1.47.
Contributor
Author
There was a problem hiding this comment.
Specifically the big [u8; 448] array in BootSector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #65 (comment), I'm generally in favour of debuggability over compile time since this seems like a micro-optimization at this scale.
I mainly needed this while debugging this crate itself, but I still think having
Debugfor all public items in a crate is useful.