Return IO object when unmounting and add flush method.#78
Open
reitermarkus wants to merge 1 commit intorafalh:masterfrom
Open
Return IO object when unmounting and add flush method.#78reitermarkus wants to merge 1 commit intorafalh:masterfrom
IO object when unmounting and add flush method.#78reitermarkus wants to merge 1 commit intorafalh:masterfrom
Conversation
reitermarkus
force-pushed
the
flush
branch
6 times, most recently
from
ab4b005 to
1ea88e4
Compare
alexkazik
reviewed
Sep 1, 2024
| } | ||
|
|
||
| self.set_dirty_flag(false)?; | ||
| Ok(()) |
There was a problem hiding this comment.
This function should call the underlying disk.flush(); (I'm currently working on a feature which requires this)
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #66 for easier review.