add cycled dims and crs capacity #31
Open
+70
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rafaqz any progress on this? This would actually be great for the spatial indexing stuff...then we can really use spatial indexing on the sphere but with lat/long bboxes. I can see some uses already :D |
|
Yeah, just needed some motivation ;) Maybe next week |
|
https://github.com/mourner/geoflatbush may be interesting in terms of how you see this... |
|
I don't know if just making Extents cyclic will get us there, but it's a start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evetion we discussed this some time and I just remembered it. So here it it.
GeoExtentcapability without a specialGeoExtentobject. We just addBoundsandCycledobjects that give use bounds with an attached crs or the same that also knows how it cycles, for anti-meridian things. Its duplicating the crs field like Rasters, but that has some nice properties for multidimensional extents, and but we can definesetcrsfor it in GeoInterface to wrap X and Y in Bounds with the crs.The trick will be actually writing out the predicates for the
cycledparts. Like we would interpret reverse order bounds to be crossing the meridean and work in relation to the cycle.Then it will be knowing where the cycle is at all from the crs. But some other packages will need to deal with that.
GeoInterface.jl can add
GI.crsto get the crs of an Extent. We could also generalise thecrsfield to bemetadataand let it accept any keywords.