Open
Conversation
kemchenj
changed the title
kemchenj
force-pushed
the
perf/cache-friendly
branch
from
740bfd8 to
aa5e86f
Compare
kemchenj
changed the title
kemchenj
force-pushed
the
perf/cache-friendly
branch
from
aa5e86f to
c074ce7
Compare
Owner
|
Hi. I remember trying something similar earlier but I didn't observe any change in performance at that time. Do you observe an improvement in performance? By how much on what machine? |
Author
|
To be honest, this change doesn't show any measurable performance improvement in my testing. However, at lease for me, I believe it makes the code somewhat easier to understand and reason about. That said, the original code might have been intentional for other reasons I'm not aware of - it really depends on the specific design considerations you had in mind. If you prefer the current implementation, I completely understand and I'm happy to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.