Skip to content

BUG: Expose id writer not being set #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BUG: Expose id writer not being set #2075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions test/fixtures/poro.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
class Model < ActiveModelSerializers::Model
rand(2).zero? && derive_attributes_from_names_and_fix_accessors

attr_writer :id
if rand(2).zero?
derive_attributes_from_names_and_fix_accessors
else
attr_writer :id
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found when using ActiveModelSerializers::Model.derive_attributes_from_names_and_fix_accessors and class SomeName < ActiveModelSerializers::Model; attributes :something; end in my own code, that SomeName.new(id: 'uuid') failed, as there was no attr_writer

end

# At this time, just for organization of intent
class_attribute :association_names
Expand Down