Remove unused CI files and provide a devcontainer setup#587
Merged
andyundso merged 2 commits intorails-sqlserver:masterfrom Jun 7, 2025
Merged
Remove unused CI files and provide a devcontainer setup#587andyundso merged 2 commits intorails-sqlserver:masterfrom
andyundso merged 2 commits intorails-sqlserver:masterfrom
Conversation
Most of them are left-overs when we switched from CircleCI to GitHub Actions in rails-sqlserver#556.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of unused files that were left over from when we switch from CircleCI to GitHub Actions.
Then there was this
docker-compose.ymlthat was meant for local development, which made use of CircleCI contains and the mentioned scripts. I decided to replace this setup with devcontainers, similar as theactiverecord-sqlserver-adapterdoes.