Merged
Conversation
Some typos jumped out at me while skimming. 😉
Contributor
Author
|
Also noticed what kind of seems like mismatching TDS version default information in the README (bitrot?), but I didn't investigate further:
If the default is now something other than 7.3, then the above line might need to be updated. 😄 |
Member
|
you're correct, this should be 7.3 instead of 7.4. if you have the chance to correct this in your PR as well, that would be nice. |
Contributor
Author
|
Sure, done. 😄 Note that the follow up typo fix was done as a separate commit, so this PR will probably need squashing if/when merged. 😄 |
andyundso
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some typos jumped out at me while skimming. 😉