Stop checking for file updates in production #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
reviewed
Jan 30, 2025
lib/mission_control/jobs/engine.rb
Outdated
| initializer "mission_control-jobs.importmap", after: "importmap" do |app| | ||
| MissionControl::Jobs.importmap.draw(root.join("config/importmap.rb")) | ||
| MissionControl::Jobs.importmap.cache_sweeper(watches: root.join("app/javascript")) | ||
| if app.config.reloading_enabled? |
Member
There was a problem hiding this comment.
Oh, great catch! This looks correct to me 👍 I see that in the original importmap-rails gem they use this condition instead:
if app.config.importmap.sweep_cache && !app.config.cache_classesMaybe this one is better? At least for consistency 🤔
Member
Author
There was a problem hiding this comment.
def reloading_enabled?
enable_reloading
end
def enable_reloading
!cache_classes
endSo reloading_enabled? is !cache_classes but with a more readable name, so I think if anything we might as well change it on the import-rails side.
I'll add the sweep_cache condition though.
While upgrading the lobsters benchmark in yjit-bench I noticed 2.8% of the overall time spent in `Dir[]`, all coming from FileUpdateChecker, which shouldn't be a think in production. After tracking it down, it comes from mission-control. Profile: https://share.firefox.dev/4hBdygq Ref: ruby/ruby-bench#358
byroot
force-pushed
the
stop-wathing-files-in-production
branch
from
9d998e3 to
d2944e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While upgrading the lobsters benchmark in yjit-bench I noticed 2.8% of the overall time spent in
Dir[], all coming from FileUpdateChecker, which shouldn't be a thing in production.After tracking it down, it comes from mission-control.
Profile: https://share.firefox.dev/4hBdygq
Ref: ruby/ruby-bench#358
NB: I'm really unfamiliar with the gem, so don't assume this PR is correct.