Skip to content

Add discard button for pending jobs #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add discard button for pending jobs #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
373ddb2
Add discard button for pending job
subins2000 Oct 8, 2025
7930352
After discard of pending job, redirect to queue
subins2000 Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/controllers/mission_control/jobs/discards_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@ def jobs_relation
end

def redirect_location
status = @job.status.presence_in(supported_job_statuses) || :failed
application_jobs_url(@application, status, **jobs_filter_param)
if @job.pending?
application_queue_path(@application, @job.queue_name)
else
status = @job.status.presence_in(supported_job_statuses) || :failed
application_jobs_url(@application, status, **jobs_filter_param)
end
end
end
3 changes: 3 additions & 0 deletions app/views/mission_control/jobs/jobs/_title.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
<div class="<%= modifier_for_status(job.status) %> tag ml-4"><%= job.status %></div>
</div>
<div class="level-right">
<% if job.pending? %>
<%= render "mission_control/jobs/jobs/pending/actions", job: job %>
<% end %>
<% if job.failed? %>
<%= render "mission_control/jobs/jobs/failed/actions", job: job %>
<% end %>
Expand Down
4 changes: 4 additions & 0 deletions app/views/mission_control/jobs/jobs/pending/_actions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<div class="buttons is-right">
<%= button_to "Discard", application_job_discard_path(@application, job.job_id, params: jobs_filter_param), class: "button is-danger is-light mr-0",
form: { data: { turbo_confirm: "This will delete the job and can't be undone. Are you sure?" } } %>
</div>