Skip to content

add mapping fix for Harsh and Harsh Deep #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

add mapping fix for Harsh and Harsh Deep #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/names_manager/canonical_names.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1193,6 +1193,7 @@ def self.map(canonical_name, *also_as)
map 'Zhang Kang', 'piecehealth', 'Kang Zhang'
map 'Zheng Jia', 'zhengjia'
map 'zzak', 'Zachary Scott'
map 'Harsh Deep', 'Harsh', "harsh.deep\100moderntreasury.com"
# Reverse SEEN_ALSO_AS to be able to go from handler to canonical name.
CANONICAL_NAME_FOR = {}
SEEN_ALSO_AS.each do |canonical_name, also_as|
Expand Down
4 changes: 4 additions & 0 deletions test/credits/canonical_names_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5159,5 +5159,9 @@ class CanonicalNamesTest < ActiveSupport::TestCase
test 'प्रथमेश Sonpatki' do
assert_contributor_names 'a7a2bc0f66', 'Prathamesh Sonpatki'
end

test 'Harsh' do
assert_contributor_names '5ff38f4', 'Harsh Deep'
end
end
end