Skip to content

Fix dhh duplicate #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix dhh duplicate #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4f431
add mapping fix for Harsh and Harsh Deep
harsh183 Oct 16, 2025
308f323
Fix DHH duplicate contributor entries
harsh183 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/names_manager/canonical_names.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ def self.map(canonical_name, *also_as)
map 'David Easley', "easleydp\100gmail.com"
map 'David Felstead', "david.felstead\100gmail.com", "dfelstead\100site5.com"
map 'David François', 'David FRANCOIS', 'davout'
map 'David Heinemeier Hansson', 'DHH', 'David' # for David see 5d5f0bad6e934d9d4fad7d0fa4643d04c13709a9
map 'David Heinemeier Hansson', 'DHH', 'dhh', 'David' # for David see 5d5f0bad6e934d9d4fad7d0fa4643d04c13709a9
map 'David Morton', "mortonda\100dgrmm.net"
map 'David N. Welton', 'davidw'
map 'David Raynes', 'rayners'
Expand Down Expand Up @@ -1193,6 +1193,7 @@ def self.map(canonical_name, *also_as)
map 'Zhang Kang', 'piecehealth', 'Kang Zhang'
map 'Zheng Jia', 'zhengjia'
map 'zzak', 'Zachary Scott'
map 'Harsh Deep', 'Harsh', "harsh.deep\100moderntreasury.com"
# Reverse SEEN_ALSO_AS to be able to go from handler to canonical name.
CANONICAL_NAME_FOR = {}
SEEN_ALSO_AS.each do |canonical_name, also_as|
Expand Down
8 changes: 8 additions & 0 deletions test/credits/canonical_names_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5159,5 +5159,13 @@ class CanonicalNamesTest < ActiveSupport::TestCase
test 'प्रथमेश Sonpatki' do
assert_contributor_names 'a7a2bc0f66', 'Prathamesh Sonpatki'
end

test 'Harsh' do
assert_contributor_names '5ff38f4', 'Harsh Deep'
end

test 'dhh' do
assert_contributor_names 'dd6f3e1', 'David Heinemeier Hansson'
end
end
end