Skip to content

Commit 77b0dd5

Browse files
authored
Document possible attack vector on get
This method is not supposed to receive user input, but if it does it will be vulnerable for a command injection attack. Closes #514
1 parent 688c3f2 commit 77b0dd5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/thor/actions/file_manipulation.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,9 @@ def link_file(source, *args)
6060
# destination. If a block is given instead of destination, the content of
6161
# the url is yielded and used as location.
6262
#
63+
# +get+ relies on open-uri, so passing application user input would provide
64+
# a command injection attack vector.
65+
#
6366
# ==== Parameters
6467
# source<String>:: the address of the given content.
6568
# destination<String>:: the relative path to the destination root.

0 commit comments

Comments
 (0)