Replace stub with allow...to receive

Author: sferik

spec/actions/create_file_spec.rb

@@ -8,7 +8,7 @@
 
   def create_file(destination=nil, config={}, options={})
     @base = MyCounter.new([1, 2], options, { :destination_root => destination_root })
-    @base.stub(:file_name).and_return('rdoc')
+    allow(@base).to receive(:file_name).and_return('rdoc')
 
     @action = Thor::Actions::CreateFile.new(@base, destination, "CONFIGURATION",
                                             { :verbose => !@silence }.merge(config))

spec/actions/create_link_spec.rb

@@ -11,7 +11,7 @@
 
   def create_link(destination=nil, config={}, options={})
     @base = MyCounter.new([1,2], options, { :destination_root => destination_root })
-    @base.stub(:file_name).and_return('rdoc')
+    allow(@base).to receive(:file_name).and_return('rdoc')
 
     @tempfile = Tempfile.new("config.rb")
 

spec/actions/directory_spec.rb

@@ -4,7 +4,7 @@
 describe Thor::Actions::Directory do
   before do
     ::FileUtils.rm_rf(destination_root)
-    invoker.stub(:file_name).and_return("rdoc")
+    allow(invoker).to receive(:file_name).and_return("rdoc")
   end
 
   def invoker

spec/actions/empty_directory_spec.rb

@@ -100,7 +100,7 @@ def base
     describe "#convert_encoded_instructions" do
       before do
         empty_directory("test_dir")
-        @action.base.stub(:file_name).and_return("expected")
+        allow(@action.base).to receive(:file_name).and_return("expected")
       end
 
       it "accepts and executes a 'legal' %\w+% encoded instruction" do

spec/actions_spec.rb

@@ -208,10 +208,10 @@ def file
         @foo = "FOO"
         say_status :cool, :padding
       TEMPLATE
-      @template.stub(:read).and_return(@template)
+      allow(@template).to receive(:read).and_return(@template)
 
       @file = '/'
-      runner.stub(:open).and_return(@template)
+      allow(runner).to receive(:open).and_return(@template)
     end
 
     it "accepts a URL as the path" do
@@ -277,7 +277,7 @@ def file
 
   describe "#run_ruby_script" do
     before do
-      Thor::Util.stub(:ruby_command).and_return("/opt/jruby")
+      allow(Thor::Util).to receive(:ruby_command).and_return("/opt/jruby")
       expect(runner).to receive(:system).with("/opt/jruby script.rb")
     end
 

spec/runner_spec.rb

@@ -130,9 +130,9 @@ def when_no_thorfiles_exist
       root_file = File.join(Thor::Util.thor_root, "thor.yml")
 
       # Stub load and save to avoid thor.yaml from being overwritten
-      YAML.stub(:load_file).and_return(@original_yaml)
-      File.stub(:exists?).with(root_file).and_return(true)
-      File.stub(:open).with(root_file, "w")
+      allow(YAML).to receive(:load_file).and_return(@original_yaml)
+      allow(File).to receive(:exists?).with(root_file).and_return(true)
+      allow(File).to receive(:open).with(root_file, "w")
     end
 
     describe "list" do
@@ -214,9 +214,9 @@ def when_no_thorfiles_exist
 
     describe "install/update" do
       before do
-        FileUtils.stub(:mkdir_p)
-        FileUtils.stub(:touch)
-        $stdin.stub(:gets).and_return("Y")
+        allow(FileUtils).to receive(:mkdir_p)
+        allow(FileUtils).to receive(:touch)
+        allow($stdin).to receive(:gets).and_return("Y")
 
         path = File.join(Thor::Util.thor_root, Digest::MD5.hexdigest(@location + "random"))
         expect(File).to receive(:open).with(path, "w")

spec/shell/basic_spec.rb

@@ -260,33 +260,33 @@ def  #456  Lanç...
     end
 
     it "returns true if the user chooses default option" do
-      $stdout.stub(:print)
+      allow($stdout).to receive(:print)
       expect($stdin).to receive(:gets).and_return('')
       expect(shell.file_collision('foo')).to be_true
     end
 
     it "returns false if the user chooses no" do
-      $stdout.stub(:print)
+      allow($stdout).to receive(:print)
       expect($stdin).to receive(:gets).and_return('n')
       expect(shell.file_collision('foo')).to be_false
     end
 
     it "returns true if the user chooses yes" do
-      $stdout.stub(:print)
+      allow($stdout).to receive(:print)
       expect($stdin).to receive(:gets).and_return('y')
       expect(shell.file_collision('foo')).to be_true
     end
 
     it "shows help usage if the user chooses help" do
-      $stdout.stub(:print)
+      allow($stdout).to receive(:print)
       expect($stdin).to receive(:gets).and_return('h')
       expect($stdin).to receive(:gets).and_return('n')
       help = capture(:stdout) { shell.file_collision('foo') }
       expect(help).to match(/h \- help, show this help/)
     end
 
     it "quits if the user chooses quit" do
-      $stdout.stub(:print)
+      allow($stdout).to receive(:print)
       expect($stdout).to receive(:puts).with('Aborting...')
       expect($stdin).to receive(:gets).and_return('q')
 
@@ -313,7 +313,7 @@ def  #456  Lanç...
       end
 
       it "invokes the diff command" do
-        $stdout.stub(:print)
+        allow($stdout).to receive(:print)
         expect($stdin).to receive(:gets).and_return('d')
         expect($stdin).to receive(:gets).and_return('n')
         expect(shell).to receive(:system).with(/diff -u/)

spec/shell/color_spec.rb

@@ -80,8 +80,8 @@ def shell
   describe "#file_collision" do
     describe "when a block is given" do
       it "invokes the diff command" do
-        $stdout.stub(:print)
-        $stdout.stub(:tty?).and_return(true)
+        allow($stdout).to receive(:print)
+        allow($stdout).to receive(:tty?).and_return(true)
         expect($stdin).to receive(:gets).and_return('d')
         expect($stdin).to receive(:gets).and_return('n')
 

spec/util_spec.rb

@@ -120,7 +120,7 @@ def self.clear_user_home!
 
   describe "#user_home" do
     before do
-      ENV.stub(:[])
+      allow(ENV).to receive(:[])
       Thor::Util.clear_user_home!
     end
 
@@ -145,30 +145,30 @@ def self.clear_user_home!
     end
 
     it "returns HOME/.thor if set" do
-      ENV.stub(:[]).with("HOME").and_return("/home/user/")
+      allow(ENV).to receive(:[]).with("HOME").and_return("/home/user/")
       expect(Thor::Util.user_home).to eq("/home/user/")
     end
 
     it "returns path with HOMEDRIVE and HOMEPATH if set" do
-      ENV.stub(:[]).with("HOMEDRIVE").and_return("D:/")
-      ENV.stub(:[]).with("HOMEPATH").and_return("Documents and Settings/James")
+      allow(ENV).to receive(:[]).with("HOMEDRIVE").and_return("D:/")
+      allow(ENV).to receive(:[]).with("HOMEPATH").and_return("Documents and Settings/James")
       expect(Thor::Util.user_home).to eq("D:/Documents and Settings/James")
     end
 
     it "returns APPDATA/.thor if set" do
-      ENV.stub(:[]).with("APPDATA").and_return("/home/user/")
+      allow(ENV).to receive(:[]).with("APPDATA").and_return("/home/user/")
       expect(Thor::Util.user_home).to eq("/home/user/")
     end
   end
 
   describe "#thor_root_glob" do
     before do
-      ENV.stub(:[])
+      allow(ENV).to receive(:[])
       Thor::Util.clear_user_home!
     end
 
     it "escapes globs in path" do
-      ENV.stub(:[]).with("HOME").and_return("/home/user{1}/")
+      allow(ENV).to receive(:[]).with("HOME").and_return("/home/user{1}/")
       expect(Dir).to receive(:[]).with("/home/user\\{1\\}/.thor/*").and_return([])
       expect(Thor::Util.thor_root_glob).to eq([])
     end