Fix ticket notification test where clicking on email link was broken #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a broken test in the ticket notifications feature in the scenario "Ticket owner is automatically subscribed to a ticket"
When an email was sent for it included a link to an image (the logo) as well as a link to the ticket.
The cucumber feature was attempting to click the link to the ticket
Then they click the first link in the email. It turns out that this was opening the image (logo) url instead of the ticket link. It might be a bug with email-spec.A simple fix to the problem is to explicitly name the link that we are trying to click with
Then they follow "view this ticket online here" in the email.