Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ jobs:
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: "18"
node-version: "20"
- name: Install ImageMagick
run: sudo apt-get install imagemagick
- name: Setup application
Expand Down
10 changes: 9 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ Example installation on macOS using Homebrew:
brew install imagemagick
# install google chrome with cask:
brew install brew-cask
brew cask install google-chrome
brew install google-chrome --cask
# install mysql
brew install mysql
# install openssl
brew install openssl@3
```

Example installation on Ubuntu:
Expand All @@ -50,6 +54,10 @@ sudo apt update -y && wget https://dl.google.com/linux/direct/google-chrome-stab
Then you need to do this one-time setup:

```bash
# On Mac, you may run into problems with the mysql2 gem that require flags to be set in bundle config
# See: https://github.com/brianmario/mysql2/issues/1345
bundle config build.mysql2 '-- --with-cflags="-Wno-error=implicit-function-declaration" --with-ldflags=-L/opt/homebrew/opt/zstd/lib'

bundle install
yarn install
# install dependencies for each appraisal:
Expand Down
2 changes: 1 addition & 1 deletion lib/rails_admin/config/configurable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def self.included(base)
base.send :extend, ClassMethods
end

def has_option?(name) # rubocop:disable Naming/PredicateName
def has_option?(name) # rubocop:disable Naming/PredicatePrefix?
options = self.class.instance_variable_get('@config_options')
options&.key?(name)
end
Expand Down
Loading