Skip to content

Conversation

@bjufre
Copy link
Contributor

@bjufre bjufre commented Jun 12, 2025

See elixir-lang/elixir#14381 for details.

With Elixir 1.19, this fixes the following kind of warnings:

==> bankster
Compiling 3 files (.ex)
    warning: storing and reading regexes from module attributes is deprecated, inline the regex inside the function definition instead
    │
 19 │     do: Regex.match?(@bic_validation_regex, String.replace(bic, ~r/\s*/, ""))
    │     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    │
    └─ lib/bankster/bic.ex:19: Bankster.Bic.valid?/1

Copy link
Owner

@railsmechanic railsmechanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for your pull request.

@railsmechanic railsmechanic merged commit 2ddbb49 into railsmechanic:master Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants