Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the RSS feed from an button to a link for better semantic, increases the outline offset, and adds screen reader-only text to comply with Success Criterion 1.1.1 (Non-text content).
I assume it was a button with
window.open()before to open it in a new tab. This can be replicated withtarget="_blank" rel="noopener noreferrer"instead. I haven't done so since it's generally a bad practice to take control over this from the user, but we can change if there's a reason to.These changes were tested manually with NVDA on Windows. For reference, before the element was announced as "button", and with the changes, "rss feed, link".