Conversation
reactive-firewall
left a comment
There was a problem hiding this comment.
👍 LGTM;
☑️ Specifically, the alignment with PEP-735 is approved once pip-tools supports the feature!
Additional Comments:
- It might be worth holding off on releasing this until tox and poetry are updated too. 🤷
- BLOCKED until jazzband/pip-tools#2175 or equivalent is implemented.
|
I am not sure why PEP 735 support by |
|
Got it: Unfortunately, With Python 3.9, it attempts to install the latest version of virtualenv (20.36.1), and in turn to install filelock 3.20.1, which fails of course, because filelock ≥ 3.20.1 is not compatible with Python 3.9. That's one reason why I suggest moving to |
Indeed, as you say. Also because you asked, and to clarify: poetry will not be a blocker for this.
And of course the bug is in "filelock>=3.16.1,<4; python_version<'3.10'",
"filelock>=3.20.1,<4; python_version>='3.10'",is obviously a mistake as it should be (see PEP-440) 🤦 I'm opening the bug report now. |
|
Turns out the last version filelock to support python3.9 was I've opened pypa/virtualenv#3037 and submitted a possible fix to the virtualenv side: pypa/virtualenv#3038 Hopefully that helps clear the way for this PR |
|
💁 After talking with the people over on
Originally posted by sirosen in #2062 From other discussions they seem a bit swamped over there (I've been shoed away for taking too much of their time) |
c2db91a to
1ba885b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev-v5.6 #299 +/- ##
=========================================
Coverage 99.59% 99.59%
=========================================
Files 1 1
Lines 491 491
=========================================
Hits 489 489
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Patch Notes
This pull request migrates the project's dependency management to comply with PEP-735 by refactoring the
pyproject.tomlfile. It replaces the deprecated[project.optional-dependencies]section with the new standardized[dependency-groups]format, enhancing clarity and organization for managing development dependencies.Comprehensive Table of Package Managers Supporting PEP 735
--dependency-groupsoption.Original Description
Here's an explanation borrowed from astral-sh/uv#8981 (comment):