Conversation
…plain sheet button
jinchung
requested review from
jinchung
and removed request for
christianbaroni and
natew
walmat
left a comment
walmat
left a comment
There was a problem hiding this comment.
Seems like there were lots of changes in here unrelated to king of the hill, were those intentional? I also noticed that you left out the Android route for the explain sheet.
| const profilesEnabled = useExperimentalFlag(PROFILES); | ||
| const marginBottom = TAB_BAR_HEIGHT + safeAreaInsetValues.bottom + 16; | ||
| const marginBottom = TAB_BAR_HEIGHT; | ||
| // safeAreaInsetValues.bottom + 16; |
There was a problem hiding this comment.
rm? iirc this was added because search rows were underflowing the bottom tab bar. Might be good to verify this isn't needed anymore.
There was a problem hiding this comment.
Removed commented out code but this calc is for the scrollview viewport which with the extra + 16 gets an incorrect calculation that results in a 16 height black bar at the top of the tab bar.
src/components/asset-list/RecyclerAssetList2/FastComponents/FastCurrencySelectionRow.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
was GradientText broken here? Or why was this removed?
There was a problem hiding this comment.
The way the previous implementation of GradientText worked would have made it more difficult to adapt here than I think it's worth for the sake of just one explain sheet type.
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
…or both android & ios
|
I fixed the |
walmat
left a comment
walmat
left a comment
There was a problem hiding this comment.
couple nits but looks good now, great work
| import { analytics } from '@/analytics'; | ||
| import { PROFILES, useExperimentalFlag } from '@/config'; | ||
| import { useAccountSettings, useSearchCurrencyList, usePrevious, useHardwareBackOnFocus } from '@/hooks'; | ||
| import { useAccountSettings, useSearchCurrencyList, usePrevious, useHardwareBackOnFocus, useDimensions } from '@/hooks'; |
There was a problem hiding this comment.
| import { useAccountSettings, useSearchCurrencyList, usePrevious, useHardwareBackOnFocus, useDimensions } from '@/hooks'; | |
| import { useAccountSettings, useSearchCurrencyList, usePrevious, useHardwareBackOnFocus } from '@/hooks'; |
unused
| const profilesEnabled = useExperimentalFlag(PROFILES); | ||
| const marginBottom = TAB_BAR_HEIGHT + safeAreaInsetValues.bottom + 16; | ||
| const TOP_OFFSET = safeAreaInsetValues.top + navbarHeight; | ||
| const MARGIN_BOTTOM = TAB_BAR_HEIGHT; |
There was a problem hiding this comment.
nitpick, but if this isn't different than the TAB_BAR_HEIGHT now we should just remove this assignment and use TAB_BAR_HEIGHT directly.
4 participants
What changed (plus any additional context for devs)
Main changes
Other changes
openVerfiedExplainerlogic in search section list, as the logic for determining if the section was the verified seciton was wrong so it never worked anyways. Also, unlikely users even know you can click the headerRemoteCardCarouseluseEffectin thePointsProfileContextScreen recordings / screenshots
RPReplay_Final1745539988.mov
What to test