add clearTimeout to ChartPathProvider useEffect#30
Open
ideopunk wants to merge 4 commits intorainbow-me:masterfrom
Open
add clearTimeout to ChartPathProvider useEffect#30ideopunk wants to merge 4 commits intorainbow-me:masterfrom
ideopunk wants to merge 4 commits intorainbow-me:masterfrom
Conversation
Contributor
|
can you remove all changes related to whitespaces? |
|
I think you can just use the first commit and drop other 3. |
GloWE3
approved these changes
Sep 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of ChartPathProvider triggers a memory leak warning, because the timeout in ChartPathProvider's main useEffect isn't cleared on unmount. This PR adds a clean-up.