Skip to content

Use correct ThreadId to avoid error end time is before its start #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangzq wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use correct ThreadId to avoid error end time is before its start #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions TraceEventLogger/TraceEventLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ private void ProjectStartedHandler(object sender, ProjectStartedEventArgs args)
name = $"Project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId})",
ph = "B",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
args = new Dictionary<string, string> {{"targets", args.TargetNames}},
};
Expand All @@ -69,7 +69,7 @@ private void ProjectStartedHandler(object sender, ProjectStartedEventArgs args)
name = $"MSBuild \"{args.ProjectFile}\"",
ph = "s",
ts = (callingMsbuildTaskInvocation.Timestamp - firstObservedTime).TotalMicroseconds() + 1,
tid = args.ParentProjectBuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.ParentProjectBuildEventContext.NodeId.ToString(),
args = new Dictionary<string, string> {{"targets", args.TargetNames}},
id = args.BuildEventContext.BuildRequestId.ToString(),
Expand All @@ -83,7 +83,7 @@ private void ProjectStartedHandler(object sender, ProjectStartedEventArgs args)
name = $"MSBuild \"{args.ProjectFile}\"",
ph = "f",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds() - 1,
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
args = new Dictionary<string, string> {{"targets", args.TargetNames}},
id = args.BuildEventContext.BuildRequestId.ToString(),
Expand All @@ -100,7 +100,7 @@ private void ProjectFinishedHandler(object sender, ProjectFinishedEventArgs args
name = $"Project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId})",
ph = "E",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
};

Expand All @@ -116,7 +116,7 @@ private void TargetStartedHandler(object sender, TargetStartedEventArgs args)
$"Target \"{args.TargetName}\" in project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId})",
ph = "B",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
};

Expand All @@ -131,7 +131,7 @@ private void TargetFinishedHandler(object sender, TargetFinishedEventArgs args)
$"Target \"{args.TargetName}\" in project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId})",
ph = "E",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
};

Expand All @@ -150,7 +150,7 @@ private void TaskStartedHandler(object sender, TaskStartedEventArgs args)
$"MSBuild (yielded) in project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId})",
ph = "B",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
};

Expand All @@ -168,7 +168,7 @@ private void TaskFinishedHandler(object sender, TaskFinishedEventArgs args)
$"MSBuild (yielded) in project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId})",
ph = "E",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId.ToString(),
};

Expand All @@ -189,7 +189,7 @@ private void EventSourceOnAnyEventRaised(object sender, BuildEventArgs buildEven
$"Project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId}) evaluation",
ph = "B",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId == BuildEventContext.InvalidNodeId ? "Evaluation" : args.BuildEventContext.NodeId.ToString(),
};
break;
Expand All @@ -200,7 +200,7 @@ private void EventSourceOnAnyEventRaised(object sender, BuildEventArgs buildEven
$"Project \"{args.ProjectFile}\" ({args.BuildEventContext.ProjectInstanceId}) evaluation",
ph = "E",
ts = (args.Timestamp - firstObservedTime).TotalMicroseconds(),
tid = args.BuildEventContext.ProjectInstanceId,
tid = args.ThreadId,
pid = args.BuildEventContext.NodeId == BuildEventContext.InvalidNodeId ? "Evaluation" : args.BuildEventContext.NodeId.ToString(),
};

Expand Down