Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration#56
Open
rajaskakodkar wants to merge 1 commit intomainfrom
Open
Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration#56rajaskakodkar wants to merge 1 commit intomainfrom
rajaskakodkar wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Rajas Kakodkar <rkakodkar@vmware.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajaskakodkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Owner
Author
|
/hold |
Merged
Owner
Author
|
/title Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration |
Owner
Author
|
/retitle Reflect changes in Testgrid config post s3 migration and prow.tanzu.io migration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on migration of prow logs to S3.
Front end of testgrid could be generated with the changes in this PR.
However, testgrid backend has updater controller which checks for Prow job logs and populates cells in testgrid. This controller currently accepts only GCS buckets for source of truth of Prow job logs and does not work with S3.
This PR should be merged only when updater supports S3.
Signed-off-by: Rajas Kakodkar rkakodkar@vmware.com