Added Amazon ECR Credential Helper

[yashsingh74]

This PR aims to add the amazon ECR credential helper.

[prowtce]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yashsingh74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [yashsingh74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yashsingh74]

Please check and review.
I also need the following information <aws_account_id> and to be added in the run.sh file.

Q. Is it ok to add the AWS Account ID publicly open in the run.sh?

[rajaskakodkar]

Left some comments otherwise lgtm. Also, lets try this locally before updating the job.

[rajaskakodkar]

Can you please add this inside the if [[ "${REGISTRY_ENABLED}" == "true" ]]; then block?

[rajaskakodkar]

I wonder if this is required based on https://github.com/awslabs/amazon-ecr-credential-helper#docker

[yashsingh74]

I removed the credHelpers. It is not needed for pull and push for docker images.

[rajaskakodkar]

Q. Is it ok to add the AWS Account ID publicly open in the run.sh?

I think it should be ok, however, I wonder if we will require it for public ECR.

[rajaskakodkar]

Lets merge this post infra migration.

/hold

[rajaskakodkar]

https://github.com/awslabs/amazon-ecr-credential-helper#troubleshooting mentions that logs can be captured in ~/.ecr/log. I think it'd be cool to push these logs as part of prow $ARTIFACTS. However, we need to verify that the logs are clean.