add deploy config for new Prow POC cluster#63
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Priyankasaggu11929
force-pushed
the
prow-poc-infra-migration
branch
from
19b6797 to
c6ebb61
Compare
|
@AndyTauber @rajaskakodkar please review! |
rajaskakodkar
left a comment
rajaskakodkar
left a comment
There was a problem hiding this comment.
quickly skimmed through this and added few comments
| volumes: | ||
| - name: github-token | ||
| secret: | ||
| secretName: github-token |
There was a problem hiding this comment.
this should be github personal access token right?
| annotations: | ||
| eks.amazonaws.com/audience: sts.amazonaws.com | ||
| eks.amazonaws.com/role-arn: arn:aws:iam::609817409085:role/prow-ecr | ||
| eks.amazonaws.com/role-arn: xyz |
There was a problem hiding this comment.
shouldn't we give this the correct role name?
There was a problem hiding this comment.
I was thinking if we could update this one with the external secrets PR #62 getting merged?
There was a problem hiding this comment.
that works as well. Is #62 updated? Is it in a state to be reviewed?
Priyankasaggu11929
force-pushed
the
prow-poc-infra-migration
branch
from
c6ebb61 to
bb0a94d
Compare
|
/lgtm |
|
/joke |
|
@Priyankasaggu11929 crier service is not present in this PR. Can you please check? |
@rajaskakodkar, addressed ^ in #64 |
2 participants
The PR contains the source of truth deployment configuration files for the new Prow POC cluster deployed as part of the infra migration, from Individual account to group ES account.