Skip to content

Translate and rename user interface functions#100

Merged
rajko-horvat merged 12 commits intorajko-horvat:masterfrom
VladimirMakeev:dialogs
Nov 1, 2025
Merged

Translate and rename user interface functions#100
rajko-horvat merged 12 commits intorajko-horvat:masterfrom
VladimirMakeev:dialogs

Conversation

@VladimirMakeev
Copy link
Contributor

Description of Changes

  • Give proper names and translate some user interface related functions;
  • Game settings flags were moved to a separate class with properly named access methods;
  • Variables storing current mouse coordinates and button state were renamed;
  • Variable used for setting up style of dialog shown by F0_1238_001e_ShowDialog was changed to a enum with comments about possible values.

Rationale behind Changes

Code cleanup, translation.

Suggested Testing Steps

Check these menus and dialogs, they should work as expected:

  • Dialog asking player to enter its name at the start of the game;
  • 'Top' menu bar with all its menus: 'Game', 'Orders', 'Advisors', 'World' and 'Civilopedia';
  • 'Game' menu (shortcut Alt+G) with its 'Options' submenu;
  • 'Find city' dialog (shortcuts ?, /) and its logic;
  • 'Advisors' menu (shortcut Alt+A) with all its options;
  • Dialog asking player to enter a custom city name after settlers had build it.

Mouse should also work as expected.

Function implements 'find city' dialog with all necessary logic
It is responsible for message box style
F0_2c84_00ad function implements game menu
Function shows and handles menu at the top of game screen
Give proper names to functions showing advisors windows
@rajko-horvat rajko-horvat self-requested a review November 1, 2025 13:35
@rajko-horvat rajko-horvat self-assigned this Nov 1, 2025
# Conflicts:
#	src/CivGame/Game/Overlay_23.cs
@rajko-horvat rajko-horvat merged commit e0d157a into rajko-horvat:master Nov 1, 2025
3 checks passed
@VladimirMakeev VladimirMakeev deleted the dialogs branch November 1, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants