Use UnitEnum instead of magic numbers#98
Merged
rajko-horvat merged 1 commit intorajko-horvat:masterfrom Oct 23, 2025
Merged
Conversation
Owner
|
Dear @VladimirMakeev I have seen you commit, but haven't managed to give it a proper check. Please bear with me a few more days ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Use
UnitEnuminstead of 'magic' numbers throughout codebase.Rationale behind Changes
Easier to understand which types of units are used in game logic.
Suggested Testing Steps
Check military status, military losses (F2) and diplomacy (meet with king) menus in game.