Disable rpath in cross compiled C extensions#165
Merged
Conversation
This instructs cross rubies to omit the rpath linker option to the absolute path in the build environment, which is like ``` -Wl,-rpath,/home/kanis/.rvm/rubies/ruby-3.4.5/lib ``` This path is not present on the target system and could lead to security issues. Related to sparklemotion/nokogiri#3133
larskanis
added a commit
to larskanis/ruby-pg
that referenced
this pull request
Aug 29, 2025
There are several absolute paths built into the binary. For instance fallback path to `pg_service.conf` or the fallback path to kerberos ccache file or the rpath included into the libpq or C-ext files. They can be avoided or fixed by disabling rpaths and by using `DESTDIR` instead of `--prefix` configure option. Fixes ged#666 The remaining rpath to libruby will probably be fixed by: rake-compiler/rake-compiler-dock#165 Also fix the `MAKEFLAGS` option. `MAKEOPTS` was wrong.
larskanis
added a commit
to larskanis/ruby-pg
that referenced
this pull request
Aug 29, 2025
There are several absolute paths built into the binary. For instance fallback path to `pg_service.conf` or the fallback path to kerberos ccache file or the rpath included into the libpq or C-ext files. They can be avoided or fixed by disabling rpaths and by using `DESTDIR` instead of `--prefix` configure option. Fixes ged#666 The remaining rpath to libruby will probably be fixed by: rake-compiler/rake-compiler-dock#165 Also fix the `MAKEFLAGS` option. `MAKEOPTS` was wrong.
larskanis
force-pushed
the
disable-rpath
branch
from
9abe89c to
01b28d5
Compare
larskanis
force-pushed
the
disable-rpath
branch
from
01b28d5 to
d99391b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This instructs cross rubies to omit the rpath linker option to the absolute path in the build environment, which is like
This path is not present on the target system and could lead to security issues.
Related to sparklemotion/nokogiri#3133 and ged/ruby-pg#668