Skip to content

feat: add string rule to the core rules #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add string rule to the core rules #133

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2936b98
feat: add string rule to the core rules
ashleyhood Dec 10, 2020
5910701
Create test for String rule
ashleyhood Jan 11, 2021
67e63a2
fixed incorrect class name
ashleyhood Feb 17, 2021
ea004be
fixed class name clash
ashleyhood Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Rules/String.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Rakit\Validation\Rule;

class Alpha extends Rule
class String extends Rule
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PHP, case is often not important, so "String" cannot be used for the class name. It would be possible to write "StringRule", but this is not customary inside the library. I suggest renaming the class to "Text" and renaming the rule to "text". Maybe something doesn't sound right, I used a translator.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chamber6821.

That will teach me for doing too many things at once, late at night 😛

{

/** @var string */
Expand Down