-
Notifications
You must be signed in to change notification settings - Fork 148
feat: add string rule to the core rules #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ashleyhood
wants to merge
4
commits into
rakit:master
Choose a base branch
from
ashleyhood:ashleyhood-patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
<?php | ||
|
||
namespace Rakit\Validation\Rules; | ||
|
||
use Rakit\Validation\Rule; | ||
|
||
class String extends Rule | ||
{ | ||
|
||
/** @var string */ | ||
protected $message = "The :attribute only allows a string"; | ||
|
||
/** | ||
* Check the $value is valid | ||
* | ||
* @param mixed $value | ||
* @return bool | ||
*/ | ||
public function check($value): bool | ||
{ | ||
return is_string($value); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<?php | ||
|
||
namespace Rakit\Validation\Tests; | ||
|
||
use Rakit\Validation\Rules\String; | ||
use PHPUnit\Framework\TestCase; | ||
use stdClass; | ||
|
||
class StringTest extends TestCase | ||
{ | ||
|
||
public function setUp() | ||
{ | ||
$this->rule = new String; | ||
} | ||
|
||
public function testValids() | ||
{ | ||
$this->assertTrue($this->rule->check('foo')); | ||
$this->assertTrue($this->rule->check('123asd')); | ||
$this->assertTrue($this->rule->check('asd123')); | ||
$this->assertTrue($this->rule->check('foo123bar')); | ||
$this->assertTrue($this->rule->check('foo bar')); | ||
$this->assertTrue($this->rule->check('<p><a href="#">Lorem ipsum dolor sit amet</a> cum omnis voluptatum! </p>')); | ||
} | ||
|
||
public function testInvalids() | ||
{ | ||
$this->assertFalse($this->rule->check(2)); | ||
$this->assertFalse($this->rule->check([])); | ||
$this->assertFalse($this->rule->check(new stdClass)); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PHP, case is often not important, so "String" cannot be used for the class name. It would be possible to write "StringRule", but this is not customary inside the library. I suggest renaming the class to "Text" and renaming the rule to "text". Maybe something doesn't sound right, I used a translator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Chamber6821.
That will teach me for doing too many things at once, late at night 😛