Open
Conversation
If a browser uses temporary files in the same folder as destination a inotify event occurs for the temporary file and is added by libtorrent before the rename happens. In this case when removing the torrent the file associated with it did not exist anymore. Sometimes the rename happened just before libtorrent wanted to add the temporary file. In that case the torrent was not added to downloads. This fix tells libtorrent to just add files ending in .torrent. Maybe a better fix would be to add a rename handler.
If using nfs or samba files get closed with CLOSE_NOWRITE or their attributes get changed (ATTRIB). If inotify doesn't report these events a lot of files gets missed due to not being readable.
If using nfs or samba files get closed with CLOSE_NOWRITE or their attributes get changed (ATTRIB). If inotify doesn't report these events a lot of files gets missed due to not being readable.
Contributor
|
is this still relevant? |
neheb
reviewed
Apr 22, 2025
| itr->slot(itr->path + event->name); | ||
| if (itr != m_wd_list.end()) { | ||
| std::string sname(event->name); | ||
| if((sname.substr(sname.find_last_of(".") ) == ".torrent")) |
Contributor
There was a problem hiding this comment.
this looks very similar to already present code...
Contributor
Author
There was a problem hiding this comment.
Beats me, It's been over 5 years since this commit...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using nfs or samba files get closed with CLOSE_NOWRITE or their
attributes get changed (ATTRIB). If inotify doesn't report these events
a lot of files gets missed due to not being readable.