Skip to content

Comments

Implement await#284

Open
Jeremi360 wants to merge 3 commits intorakugoteam:mainfrom
Jeremi360:await-signal
Open

Implement await#284
Jeremi360 wants to merge 3 commits intorakugoteam:mainfrom
Jeremi360:await-signal

Conversation

@Jeremi360
Copy link
Contributor

Its implements #277 and also Rakugo.player_step_locked
to make possible to lock step until Rakugo received signal.

@Jeremi360 Jeremi360 added RakuScript Rakugo Scripting Dialogue Langue proposal proposal how improve Rakugo labels Apr 25, 2025
@Jeremi360 Jeremi360 added this to the 2.4 milestone Apr 25, 2025
@Jeremi360 Jeremi360 requested a review from theludovyc April 25, 2025 05:35
@Jeremi360 Jeremi360 self-assigned this Apr 25, 2025
Copy link
Collaborator

@theludovyc theludovyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test :)

@Jeremi360
Copy link
Contributor Author

@theludovyc I will add test soon

@Jeremi360
Copy link
Contributor Author

@theludovyc
Run as project RDS launch normal, but in GUT it crashes,so I had too comment out
StoreManger._init() and make small fix in Rakugo.gd to run any test - we need also fix this.

Test for await gvies me errors and I'm not sure way:

res://Test/TestExecuter/TestAwait/TestAwait.gd.
* test_await
    -- Awaiting signal "sg_execute_script_start" or for 0.2 second(s) -- 
    -- Awaiting signal "timeout" or for 0.2 second(s) -- 
    [Failed]:  Object Rakugo:<Node#28303164614> does not have the signal [timeout]
      at line -1
    -- Awaiting signal "sg_say" or for 0.2 second(s) -- 
    [Failed]:  Object Rakugo:<Node#28303164614> did not emit signal [sg_say] (Signals emitted: ["sg_execute_script_start", "sg_execute_script_finished"])
      at line -1
    -- Awaiting signal "sg_execute_script_finished" or for 0.2 second(s) -- 
    [Failed]:  Expected object Rakugo:<Node#28303164614>(Rakugo.gd) to emit signal [sg_execute_script_finished] with parameters ["TestAwait", ""] != ["TestAwait", "Executer::do_execute_scri...nt scene"]  1 of 2 indexes do not match.
      [
          1:  "" != "Executer::do_execute_script::AWAIT, there is no sender with name: Timer or in current sce...ent scene"
      ]
      at line -1
[WARNING]:  Test script has 1 unfreed children.  Increase log level for more details.
1/4 passed.

==============================================
= Run Summary
==============================================

res://Test/TestExecuter/TestAwait/TestAwait.gd
- test_await
    [Failed]:  Object Rakugo:<Node#28303164614> does not have the signal [timeout]
          at line -1
    [Failed]:  Object Rakugo:<Node#28303164614> did not emit signal [sg_say] (Signals emitted: ["sg_execute_script_start", "sg_execute_script_finished"])
          at line -1
    [Failed]:  Expected object Rakugo:<Node#28303164614>(Rakugo.gd) to emit signal [sg_execute_script_finished] with parameters ["TestAwait", ""] != ["TestAwait", "Executer::do_execute_scri...nt scene"]  1 of 2 indexes do not match.
      [
          1:  "" != "Executer::do_execute_script::AWAIT, there is no sender with name: Timer or in current sce...ent scene"
      ]
          at line -1

Totals
Scripts:          1
Passing tests     0
Failing tests     1
Risky tests       0
�Pending:          0
Asserts:          1 of 4 passed

Warnings/Errors:
* 1 Warnings.

0 passed 1 failed.  Tests finished in 0.464s

[Orphans]:  1 new orphan in total.
Note:  This count does not include GUT objects that will be freed upon exit.
       It also does not include any orphans created by global scripts
       loaded before tests were ran.
Total orphans = 2
Ran Scripts matching "TestAwait.gd"

@Jeremi360 Jeremi360 requested a review from theludovyc May 5, 2025 08:23
@theludovyc
Copy link
Collaborator

Same as before, please add a commit for the format 😊

@Jeremi360
Copy link
Contributor Author

Same as before, please add a commit for the format 😊

Okay @theludovyc , but what with errors in test ?
#284 (comment)

@theludovyc
Copy link
Collaborator

[Failed]: Object Rakugo:<Node#28303164614> does not have the signal [timeout] at line -1

Maybe something to study, and I need to read the code for that 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposal proposal how improve Rakugo RakuScript Rakugo Scripting Dialogue Langue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants